Make the pre-commit hook call the user's hooks, not the repository hooks
We should stop executing untrusted scripts.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.4.4.x-final in legacy/trac
changed milestone to %Tor: 0.4.4.x-final in legacy/trac
- teor added actualpoints::0.1 in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.4.4.x-final in Legacy / Trac no-backport in Legacy / Trac owner::teor in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::nickm in Legacy / Trac security-low in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::tor 0.4.1.1-alpha in Legacy / Trac labels
added actualpoints::0.1 in Legacy / Trac component::core tor/tor in Legacy / Trac milestone::Tor: 0.4.4.x-final in Legacy / Trac no-backport in Legacy / Trac owner::teor in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::nickm in Legacy / Trac security-low in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac version::tor 0.4.1.1-alpha in Legacy / Trac labels
This fix also avoids errors from outdated git hooks, when a backport branch is checked out during a push.
See my PR:
Trac:
Status: assigned to needs_review
Actualpoints: N/A to 0.1- Owner
LGTM. I am confused about why this doesn't need to be in quotes:
pre_commit=${gitdir}/hooks/pre-commit
but apparently it doesn't.
Merged to master.
Trac:
Resolution: N/A to fixed
Status: needs_review to closed - Owner
Trac:
Reviewer: N/A to nickm - Trac closed
closed
- Trac changed time estimate to 48m
changed time estimate to 48m
- Trac added 48m of time spent
added 48m of time spent
- Trac moved from legacy/trac#33284 (moved)
moved from legacy/trac#33284 (moved)
- Trac added 1 deleted label and removed 1 deleted label
added 1 deleted label and removed 1 deleted label