Require IPv6 tests in Travis CI
While we're actively changing our IPv6 code, we should make sure that the macOS chutney IPv6 tests pass in Travis CI.
While I'm doing this change, I will see if there are:
- some redundant jobs I can delete, or
- some inactive areas that I can make fast_finish.
I think our Rust build might be a good candidate for fast_finish, we haven't changed that code much in about a year. But I should check with the team before making this change.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.3.5.x-final in legacy/trac
changed milestone to %Tor: 0.3.5.x-final in legacy/trac
Trac:
Parent Ticket: legacy/trac#33050 (moved)- teor added actualpoints::0.7 in Legacy / Trac chutney in Legacy / Trac component::core tor/tor in Legacy / Trac consider-backport-immediately in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.3.5.x-final in Legacy / Trac network-team-roadmap-2020Q1 in Legacy / Trac owner::teor in Legacy / Trac parent::33050 in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::nickm in Legacy / Trac severity::normal in Legacy / Trac sponsor::55-must in Legacy / Trac status::closed in Legacy / Trac tor-ci in Legacy / Trac type::task in Legacy / Trac labels
added actualpoints::0.7 in Legacy / Trac chutney in Legacy / Trac component::core tor/tor in Legacy / Trac consider-backport-immediately in Legacy / Trac ipv6 in Legacy / Trac milestone::Tor: 0.3.5.x-final in Legacy / Trac network-team-roadmap-2020Q1 in Legacy / Trac owner::teor in Legacy / Trac parent::33050 in Legacy / Trac points::0.1 in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::nickm in Legacy / Trac severity::normal in Legacy / Trac sponsor::55-must in Legacy / Trac status::closed in Legacy / Trac tor-ci in Legacy / Trac type::task in Legacy / Trac labels
Trac:
Parent: legacy/trac#33194 (moved) to legacy/trac#33050 (moved)We need to merge the legacy/trac#33075 (moved) backport, before making these changes.
We can delete the following redundant jobs:
- Linux clang distcheck
- I think this job was actually an 0.2.9 merge forward error
We need to speed up the macOS chutney IPv6 job, because it runs for 23-46 minutes:
- run IPv4-only in Linux, and IPv6-only in macOS
- Linux clang distcheck
See my PRs:
Backport require IPv6 chutney to pass, remove a redundant job, reorder jobs (legacy/trac#33194 (moved) and legacy/trac#33195 (moved)):
- 0.3.5: https://github.com/torproject/tor/pull/1732
- 0.4.1: https://github.com/torproject/tor/pull/1733
- 0.4.2: https://github.com/torproject/tor/pull/1734
- 0.4.3: https://github.com/torproject/tor/pull/1735
Split IPv4 and IPv6 chutney tests, and only run IPv6 on macOS (legacy/trac#33280 (moved) and legacy/trac#33303 (moved)):
I think it's worth backporting these changes, they are travis-only, and should make a significant difference to CI speeds during backport merges.
Trac:
Keywords: N/A deleted, ipv6, consider-backport-immediately added
Reviewer: N/A to nickm
Cc: N/A to nickm
Actualpoints: N/A to 0.6
Status: assigned to needs_reviewThere is also a master test branch, without legacy/trac#33280 (moved):
- Owner
I've left comments on https://github.com/torproject/tor/pull/1731 .
As for backporting, I agree with backporting the travis changes, but: let's try them in master for a week or so before we backport, in case they turn out to have unforseen drawbacks.
Trac:
Status: needs_review to needs_revision I just compared master and this PR:
- https://travis-ci.org/torproject/tor/builds/650218289
- https://travis-ci.org/torproject/tor/builds/650232465
Both finish in about 18 minutes, the IPv6-only tests take 12 minutes on macOS.
I think that's a win, because we:
- added a slow chutney job (25-45 minutes), but made it faster (13 minutes), and
- deleted a redundant distcheck job (8 minutes), but kept the same CI wall clock run time.
(The extra 5 minutes for the chutney job is hidden by the parallelism.)
- Owner
LGTM. Let's merge this in into master and let it cook for a little while.
Trac:
Status: needs_review to merge_ready Merged to master, because I needed it for legacy/trac#33334 (moved).
I had to re-do the legacy/trac#33280 (moved) and legacy/trac#33195 (moved) merge, because the "ours" merge deleted some commits that were merged into 0.4.3 after the branches split off from master.
Trac:
Keywords: consider-backport-immediately deleted, consider-backport-after-0433 added
Milestone: Tor: 0.4.4.x-final to Tor: 0.4.3.x-finalMerged to 0.3.5 and later, because I need it for legacy/trac#33048 (moved).
We also want to have consistent tor-chutney CI, particularly now that legacy/trac#33232 (moved) is merged.
Trac:
Milestone: Tor: 0.4.3.x-final to Tor: 0.3.5.x-final
Status: merge_ready to closed
Keywords: consider-backport-after-0433 deleted, consider-backport-immediately added
Resolution: N/A to fixed- Trac closed
closed
- Trac changed time estimate to 48m
changed time estimate to 48m
- Trac added 5h 36m of time spent
added 5h 36m of time spent
- teor mentioned in issue legacy/trac#33280 (moved)
mentioned in issue legacy/trac#33280 (moved)