Implement EOY home screen

See torbutton#40013 (closed)

changed milestone to %Tor Browser: 10.0

added 1 deleted label

Hrm! Exciting. Android doesn't natively support SVG, but SVG can be converted into the Android Vector drawable. Unfortunately, illo.svg contains a very-long-path and Android crashes, as a result.

error: string too large to encode using UTF-8 written instead as 'STRING_TOO_LARGE'.

At runtime we get:

10-27 16:31:14.084  5609  5609 E AndroidRuntime: FATAL EXCEPTION: main
10-27 16:31:14.084  5609  5609 E AndroidRuntime: Process: org.torproject.torbrowser_debug, PID: 5609
10-27 16:31:14.084  5609  5609 E AndroidRuntime: android.view.InflateException: Binary XML file line #116 in org.torproject.torbrowser_debug:layout/fragment_home: Binary XML file line #116 in org.torproject.torbrowser_debug:layout/fragment_home: Error inflating class ImageView
10-27 16:31:14.084  5609  5609 E AndroidRuntime: Caused by: android.view.InflateException: Binary XML file line #116 in org.torproject.torbrowser_debug:layout/fragment_home: Error inflating class ImageView
10-27 16:31:14.084  5609  5609 E AndroidRuntime: Caused by: android.content.res.Resources$NotFoundException: Drawable org.torproject.torbrowser_debug:drawable/ic_illo with resource ID #0x7f080171
10-27 16:31:14.084  5609  5609 E AndroidRuntime: Caused by: android.content.res.Resources$NotFoundException: File res/drawable/ic_illo.xml from drawable resource ID #0x7f080171
10-27 16:31:14.084  5609  5609 E AndroidRuntime: 	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:876)
[...]
10-27 16:31:14.086  5609  5609 E AndroidRuntime: Caused by: java.lang.IllegalArgumentException: R is not a valid verb. Failure occurred at position 2 of path: STRING_TOO_LARGE
10-27 16:31:14.086  5609  5609 E AndroidRuntime: 	at android.util.PathParser.nCreatePathDataFromString(Native Method)
10-27 16:31:14.086  5609  5609 E AndroidRuntime: 	at android.util.PathParser.access$200(PathParser.java:25)
10-27 16:31:14.086  5609  5609 E AndroidRuntime: 	at android.util.PathParser$PathData.<init>(PathParser.java:78)

https://brightinventions.pl/blog/string-too-large-in-android-resources

Decompiling the apk (using apktool)

$ grep -n STRING_TOO_LARGE app-x86_64-debug/res/drawable/ic_illo.xml 
4182:    <path android:fillColor="#ff00ff00" android:pathData="STRING_TOO_LARGE" android:fillType="evenOdd" />

I deleted that path, and now I see the path causing the problem is the onion :(

@antonela do you have a png I can use?

We have the same problem with tape.svg.

Ah. tape.svg uses one, long path. :/

I converted the svg files using inkscape :)

I added the .png for TB high-sec mode fallback in the desktop ticket. These works anyways!

@antonela

In torbutton#40013 (comment 2710359) you asked if we need a different patch. We do need it. :/

Do you like this design or do you have a vision for better layout?

I think I like these better. Ideally, we'd use different layouts on small and large screens, but I prefer improving that later. The first two screenshots are a tablet, and the last is a phone.

Thanks @sysrqb for working on this! I'm attaching here the layouts we have in desktop for mobiles and tablets media breakpoints.

If we can reach something similar, then it'd be awesome. If you want/can reuse some html+css, let me know.

mentioned in merge request !61 (closed)

mentioned in merge request !63 (merged)

closed with merge request !63 (merged)