Split {feature,core,app}/*/include.am out of core/include.am

It seems a bit weird that we're missing feature/include.am, maybe it's time to fix that.

changed milestone to %Tor: 0.4.3.x-final

Trac:
Parent Ticket: #31851 (moved)

added actualpoints::.2 component::core tor/tor milestone::Tor: 0.4.3.x-final owner::nickm parent::31851 points::0.5 priority::medium resolution::implemented reviewer::catalyst severity::normal sponsor::31-can status::closed tor-design type::task labels

The original rationale was that since we do not yet have good (downward dependencies only) factoring for the layers higher than src/lib, we can't yet build them as separate libraries. But you're right that this shouldn't stop us from having separate include files here.

If we take this approach, we should probably ahve one include.am file per subdirectory, as we do for src/lib, and just base them on a different template.

Update title to reflect desired layout.

Trac:
Summary: Split feature/include.am out of core/include.am to Split {feature,core,app}/*/include.am out of core/include.am

Trac:
Owner: N/A to nickm
Status: new to accepted

See branch ticket32137 with PR at https://github.com/torproject/tor/pull/1657 . I anticipate some conflicts with #32487 (moved), but they should be tractable.

Trac:
Status: accepted to needs_review
Actualpoints: N/A to .2

Trac:
Milestone: Tor: unspecified to Tor: 0.4.3.x-final

Trac:
Reviewer: N/A to catalyst

Replying to nickm:

See branch ticket32137 with PR at https://github.com/torproject/tor/pull/1657 . I anticipate some conflicts with #32487 (moved), but they should be tractable. Other than the existing bugs noted in #32962 (moved), this looks good.

Trac:
Status: needs_review to merge_ready

Thank you for the review, catalyst! Merging to master.

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 4h

added 1h 36m of time spent

mentioned in issue #32487 (moved)

mentioned in issue #32709 (moved)

mentioned in issue #32962 (moved)

mentioned in issue #31851 (moved)

moved to tpo/core/tor#32137 (closed)