Restrict "make test-stem" to tests that actually use tor

In #30694 (moved), we restricted the travis stem job to tests that actually use tor.

But we should lower that change to "make test-stem".

Gaba, this is sponsor 27 can, because it makes refactoring easier to test.

changed milestone to %Tor: 0.3.5.x-final

added 035-backport 040-backport 041-backport actualpoints::0.2 component::core tor/tor dgoulet-merge fast-fix milestone::Tor: 0.3.5.x-final owner::teor points::0.1 priority::medium resolution::fixed reviewer::nickm severity::normal sponsor::31-can status::closed tor-ci type::enhancement labels

See my pull request: 0.3.5: https://github.com/torproject/tor/pull/1271

This change merges forward cleanly to master.

The test branches are called ticket31554_* in my repository: https://github.com/teor2345/tor/branches

Trac:
Status: assigned to needs_review
Actualpoints: N/A to 0.2

This looks reasonable to me, but I wonder if it will be stable long-term. If stem adds a new group of tests that we want to cover, will it necessarily be under control.controller, control.base_controller, or process ?

(That's not a blocking problem for this ticket, but it does suggest to me that we should ask stem to incorporate an alias like RUN_ALL for these--maybe RUN_TOR_TESTS.)

I think that's a question for atagar?

Trac:
Cc: gaba to gaba, atagar

Trac:
Reviewer: N/A to asn

Replying to nickm:

This looks reasonable to me, but I wonder if it will be stable long-term. If stem adds a new group of tests that we want to cover, will it necessarily be under control.controller, control.base_controller, or process ?

(That's not a blocking problem for this ticket, but it does suggest to me that we should ask stem to incorporate an alias like RUN_ALL for these--maybe RUN_TOR_TESTS.)

I created #31593 (closed) for this.

Trac:
Status: needs_review to merge_ready

Setting myself as reviewer.

Trac:
Reviewer: asn to nickm
Status: merge_ready to needs_review
Keywords: N/A deleted, dgoulet-merge added

Trac:
Status: needs_review to merge_ready

Merged to 041 and master. Moving to 040 milestone for backport.

Trac:
Milestone: Tor: 0.4.2.x-final to Tor: 0.4.0.x-final

We need to merge this CI fix to avoid conflicts with #30901 (moved), so I'll do it as soon as CI is free and green.

Merged to maint-0.3.5 and later.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed
Milestone: Tor: 0.4.0.x-final to Tor: 0.3.5.x-final

closed

changed time estimate to 48m

added 1h 36m of time spent

mentioned in issue #31593 (closed)

moved to tpo/core/tor#31554 (closed)