Run shellcheck as part of "make check"

To avoid introducing shell script issues into Tor, we could run shellcheck (https://github.com/koalaman/shellcheck) as part of "make check".

Since this is a technical debt check, I am tentatively assigning it to 0.3.6.

changed milestone to %Tor: 0.4.0.x-final

added component::core tor/tor milestone::Tor: 0.4.0.x-final owner::rl1987 priority::medium resolution::implemented reviewer::mikeperry severity::normal status::closed technical-debt type::enhancement labels

Tor 0.3.6.x has been renamed to 0.4.0.x.

Trac:
Milestone: Tor: 0.3.6.x-final to Tor: 0.4.0.x-final

Trac:
Owner: N/A to rl1987
Status: new to accepted

https://github.com/torproject/tor/pull/594

Currently let's only cover scripts/ directory, as all scripts in there has been cleaned up to make shellcheck pass without any warnings. In tor codebase there are still quite a bit of scripts that shellcheck finds objectionable. I will open some tickets later.

Trac:
Status: accepted to needs_review

I think this needs to be something that only happens when shellcheck is installed. Unless we really want to require all developers and distributors to install shellcheck?

It does check if we have shellcheck before trying to use it:

shellcheck:
	if command -v shellcheck; then \

Oh. Yeah, you're right. Sorry, I missed that.

Trac:
Reviewer: N/A to mikeperry

Seems simple enough to me. Looks good.

Trac:
Status: needs_review to merge_ready

Actually, you know what.. Can we fix the formatting in that makefile rule, and maybe comment that the command -v thing is checking for shellcheck before running it? The fact that Nick missed that is probably a sign this code is too dense right now.

Trac:
Status: merge_ready to needs_revision

Cleaned up and commented in 49f7951ac9afae1fd67d721b77d4b766b59db3bc.

Trac:
Status: needs_revision to needs_review

Ok this looks good.

Trac:
Status: needs_review to merge_ready

Okay; squashed and merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

mentioned in issue #30263 (moved)

moved to tpo/core/tor#28058 (closed)

mentioned in issue tpo/core/tor#30263 (closed)