Add check-includes to check-local?

We now have a handy tool that lets us check our includes for modularity violations. We could make it part of "make check", and have our CI enforce it for us!

changed milestone to %Tor: 0.3.5.x-final

added 035-triaged-in-20180711 ci component::core tor/tor easy fast-fix milestone::Tor: 0.3.5.x-final modularity owner::nickm priority::medium resolution::implemented reviewer::teor severity::normal status::closed type::enhancement labels

Trac:
Owner: N/A to nickm
Keywords: easy ci modularity deleted, easy ci modularity fast-fix added
Status: new to accepted

Trac:
Status: accepted to closed
Resolution: N/A to fixed

Beg your pardon? I never actually did this.

Trac:
Resolution: fixed to N/A
Status: closed to reopened

Please see branch ticket26447 with PR at https://github.com/torproject/tor/pull/217 .

Trac:
Status: reopened to needs_review

Trac:
Keywords: easy ci modularity fast-fix deleted, 035-triaged-in-20180711, ci, easy, modularity, fast-fix added

Trac:
Reviewer: N/A to teor

Oops, sorry, I didn't see this ticket last week.

When building out of tree, I see:

perl ../scripts/maint/checkSpace.pl -C \
		../src/lib/*/*.[ch] \
		../src/core/*/*.[ch] \
		../src/feature/*/*.[ch] \
		../src/app/*/*.[ch] \
		../src/test/*.[ch] \
		../src/test/*/*.[ch] \
		../src/tools/*.[ch]
../scripts/maint/checkIncludes.py
make[1]: ../scripts/maint/checkIncludes.py: No such file or directory
make[1]: *** [check-includes] Error 1
make[1]: *** Waiting for unfinished jobs....

Trac:
Status: needs_review to needs_revision

But the file is there:

$ ls -l ../scripts/maint/checkIncludes.py
-rwxr-xr-x  1 x  staff  3473 26 Jul 10:39 ../scripts/maint/checkIncludes.py

I get the same error for an in-tree build:

perl ./scripts/maint/checkSpace.pl -C \
		./src/lib/*/*.[ch] \
		./src/core/*/*.[ch] \
		./src/feature/*/*.[ch] \
		./src/app/*/*.[ch] \
		./src/test/*.[ch] \
		./src/test/*/*.[ch] \
		./src/tools/*.[ch]
./scripts/maint/checkIncludes.py
make[1]: ./scripts/maint/checkIncludes.py: No such file or directory
make[1]: *** [check-includes] Error 1
make[1]: *** Waiting for unfinished jobs....
...
$ ls -l ./scripts/maint/checkIncludes.py
-rwxr-xr-x  1 x  wheel  3473 26 Jul 10:48 ./scripts/maint/checkIncludes.py

It's maybe complaining that you don't have a /usr/bin/python3? I'll fix it up.

Replying to nickm:

It's maybe complaining that you don't have a /usr/bin/python3? I'll fix it up.

Yeah, I don't have any python3 in that build environment. But if I did, it would be at /usr/local/bin/python3.

I've made the straightforward fix; better now?

Trac:
Status: needs_revision to needs_review

Yes, it works well now.

Trac:
Status: needs_review to merge_ready

Merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

mentioned in issue #26448 (moved)

moved to tpo/core/tor#26447 (closed)