Add a unit test for geoip_load_file()

The geoip_load_file() function has no test coverage. As a demo at the hackfest, I worked with Juga to fix that situation. Please review branch geoip_testing in my public repository.

changed milestone to %Tor: 0.3.4.x-final

added component::core tor/tor geoip milestone::Tor: 0.3.4.x-final owner::nickm priority::medium resolution::fixed reviewer::isis severity::normal status::closed tor-test type::enhancement labels

Trac:
Status: assigned to needs_review

Next steps, if we decide:

• Test loading the geoip6 file.
• Test that loading a second file truly replaces the first instead of adding to it.

Trac:
Cc: N/A to juga

Trac:
Keywords: N/A deleted, review-group-35 added
Reviewer: N/A to isis

LGTM

Trac:
Status: needs_review to merge_ready

merged to master; thanks!

Putting this back into new in case juga or someone else wants to do the other tests discussed above.

Trac:
Status: merge_ready to accepted
Keywords: review-group-35 deleted, N/A added
Milestone: Tor: 0.3.4.x-final to Tor: unspecified
Reviewer: isis to N/A

Trac:
Status: accepted to new

Is it possible that the SRCDIR "/src/config/geoip" file ends up somewhere different on windows? There's an experimental build (read: it could be lying) for part of the AppVeyor setup for #25549 (moved) which seems to claim it can't find that file.

There was a bug here that I fixed in 398bef2592010e71692dd9c3b5b90d3751c48bb2 -- is the appveyor setup on a branch that includes that fix, or did it branch earlier?

Trac:
0001-Add-a-test-for-geoip_load_file-using-geoip6.patch

Attaching test loading the geoip6 file as nickm commented above.

Trac:
Status: new to needs_review
Milestone: Tor: unspecified to Tor: 0.3.4.x-final

Trac:
Reviewer: N/A to isis

git log 398bef2592010e71692dd9c3b5b90d3751c48bb2 ^master

is empty, so it is included.

Trac:
Username: saper

saper, what do you mean by the previous comment?

#define SRCDIR "/c/projects/appveyor"

Maybe my MinGW-based setup does not like cygwin paths.

Using "c:/projects/appveyor" seems to work. There is a piece of autoconf code that tries to do the same (determine the actual source directory), maybe it should be reused?

Trac:
Username: saper

Similarly, I believe $BUILDDIR does not work either. It seems not to be used to open existing file if _WIN32 is defined.

Trac:
Username: saper

Replying to juga:

saper, what do you mean by the previous comment?

It was a reply to a question if 398bef2592010e71692dd9c3b5b90d3751c48bb2 is included in my appveyor testing branch. The answer is yes, it is included.

Trac:
Username: saper