scripts/test/coverage tries to mv .gcov files to /
When run with no arguments, the scripts/test/coverage
script attempts to move the .gcov files to the root directory. This shouldn't happen. Hopefully most users won't run this script as a UID that has write access to the root directory, but we should fix this anyway. Either exit with a usage error if there is no directory name argument, or change the test to [ -d "$dst" ]
. (The existing test, [ -n $dst ]
with no quoting around $dst
, returns true if $dst
is empty on the macOS and Linux systems I've tried it on. This surprising behavior is apparently required by POSIX.)