Rename tor_dup_addr to make it clear that it returns a string
We discovered in #18454 (moved) that it's easy to write code that assumes that tor_dup_addr duplicates an address, rather than formatting that address as a string and duplicating that string.
Let's change the name of that function to tor_addr_to_str_dup or something.