Use duckduckgo hidden service instead of clearnet one

Use duckduckgo hidden service (3g2upl4pq6kufc4m.onion) instead clearnet one

added TorBrowserTeam201601R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-5.5 tbb-usability type::enhancement labels

Trac:
Type: defect to enhancement
Keywords: N/A deleted, hidden service, duckduckgo, clearnet added
Component: - Select a component to Tor Browser
Summary: Use duckduckgo hidden service instead clearnet one to Use duckduckgo hidden service instead of clearnet one
Owner: N/A to tbb-team

this has substantial security benefits and is trivially easy to implement affects majority of users; should be done ASAP

Trac:
Priority: normal to critical

Trac:
ddg.diff

Use duckduckgo hidden service instead of clearnet one

Performing a DuckDuckGo search from the search bar after setting the Tor Browser security slider to "High" results in a search result page which states:-

"This page requires JavaScript. Get the non-JS version here"

and links to the "html" version of the search page: https://duckduckgo.com/html/?q=search+term

The .onion site already uses the html version so bundling Tor Browser with a search add-on for the .onion site would be a welcome improvement in usability.

Trac:
Username: jah
Severity: N/A to Normal
Sponsor: N/A to N/A

Replying to jah:

Performing a DuckDuckGo search from the search bar after setting the Tor Browser security slider to "High" results in a search result page which states:-

"This page requires JavaScript. Get the non-JS version here"

and links to the "html" version of the search page: https://duckduckgo.com/html/?q=search+term

This is so annoying. It would be great to get it fixed.

The .onion site already uses the html version so bundling Tor Browser with a search add-on for the .onion site would be a welcome improvement in usability.

And security and privacy.

Marked #11884 (moved) as a duplicate.

Trac:
Status: new to needs_review
Cc: N/A to biosh
Priority: Very High to Medium
Keywords: hidden service, duckduckgo, clearnet deleted, tbb-usability, TorBrowserTeam201601R added

bug_16322_v3 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_16322_v3&id=912db6de1e8851870434a948b8721cd2aebf11de) has a slightly different patch for review. It turns out we had two DDG search plugins in our tree, one added by Mozilla in https://bugzilla.mozilla.org/show_bug.cgi?id=1061736. That one gets loaded earlier than our own which causes the breakage with JavaScript disabled. Moreover, the Mozilla one tracks from where the user iss searching by adding a search parameter to the query. My patch gets rid both of that feature and of the duplicate DDG .xml. And, yes, thanks to the patch by the cypherpunk the URL gets set to the onion service now as well.

Trac:
Cc: biosh to biosh, mcs, brade
Keywords: N/A deleted, tbb-5.5 added

r=mcs, r=brade Looks good.

Thanks, this is commit 912db6de1e8851870434a948b8721cd2aebf11de on tor-browser-38.5.0esr-5.5-2.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #18151 (moved)

moved to tpo/applications/tor-browser#16322 (closed)