ESR 38 contains filenames with spaces which breaks our Gitian builds

find -type f | xargs touch --date="$REFERENCE_DATETIME" is broken if we have files with spaces in their filenames.

added TorBrowserTeam201506R component::applications/tor browser ff38-esr owner::tbb-team parent::15772 priority::medium resolution::fixed status::closed tbb-5.0a3-essential tbb-gitian type::defect labels

We should be able to fix this by using null seperators (although I have not tried it), e.g., find -type f -print0 | xargs -0 touch --date="$REFERENCE_DATETIME"

Trac:
Cc: N/A to mcs

bug_16150_v2 in my public repo (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_16150_v2) has a fix.

Trac:
Keywords: N/A deleted, TorBrowserTeam201505R added
Status: new to needs_review

Your changes look good to me.

Do you happen to know which files in ESR 38 have spaces? We have not noticed a problem with the updater yet, although previously Mozilla's MAR file generation scripts had problems handling paths that contained spaces (Kathy and I tried to fix those problems when we made the original updater changes for TB, just in case).

browser/components/migration/tests/unit/Library/Application%20Support/ caused this ticket. I have not checked systematically whether there are more instances in the tree now.

For the record, running a find command on an esr38 tree reveals the following (all part of various tests):

./browser/components/migration/tests/unit/Library/Application Support ./browser/components/migration/tests/unit/Library/Application Support/Google/Chrome/Local State ./layout/reftests/fonts/sil/Scheherazade-R 2012-07-03c.ttf ./media/webrtc/trunk/tools/gyp/test/win/command-quote/bat with spaces.bat

Trac:
Keywords: N/A deleted, TorBrowserTeam201506 added

Trac:
Keywords: TorBrowserTeam201505R, TorBrowserTeam201506 deleted, TorBrowserTeam201506R added

Tag the set of things we should aim to understand/fix for the fist FF38-based TBB (5.0a3, on June 30th).

Trac:
Keywords: N/A deleted, tbb-5.0a3-essential added

This is merged into master with commit f1783ba6746b9facbd35273d665cd48a36eb9c2f.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #16181 (moved)

mentioned in issue #16210 (moved)

moved to tpo/applications/tor-browser#16150 (closed)