Build mingw-w64 compiler for TBB bundles from source

With #9084 (closed) landed in TBB 3.0b1 we are already building mingw-w64 from source to ship our runtime libraries linked against msvcr100. We should build upon this work and use it for building the Windows TBBs, too.

added component::applications/tor browser gitian owner::tbb-team priority::medium resolution::fixed status::closed tbb-3.0 tbb-gitian type::enhancement labels

Trac:
Keywords: N/A deleted, gitian added

Trac:
Component: Tor bundles/installation to Tor Browser
Owner: erinn to tbb-team
Keywords: N/A deleted, tbb-gitian added

I believe this is fixed in my tbb-4.x-hardening branch.

Trac:
Status: new to needs_review

Replying to erinn:

I believe this is fixed in my tbb-4.x-hardening branch.

Looks good. Could you take care of https://gitweb.torproject.org/builders/tor-browser-bundle.git/blob/8a552ff03c226c3d1f5fa3ae0b4950cc03c0f678:/gitian/descriptors/windows/gitian-utils.yml#l54 as well (+ the respective parts in mkbundle-windows.sh and the three comment lines in gitian-tor.yml right before exporting PATH)? We don't need that anymore if this bug is fixed.

I fixed it and rebased the branch so it's included in the regular Windows hardening commit.

While we don't need a separate binutils anymore we might want to be able to upgrade it without upgrading mingw-w64. It seems we can't do that with the new current patch. Maybe we should go for the simplest thing like adding touch binutils-$BINUTILS_VER-win32-utils.zip near the end of the utils descriptor and just check for binutils' existence (without adding any links) in mkbundle-windows.sh?

Replying to gk:

While we don't need a separate binutils anymore we might want to be able to upgrade it without upgrading mingw-w64. It seems we can't do that with the new current patch. Maybe we should go for the simplest thing like adding touch binutils-$BINUTILS_VER-win32-utils.zip near the end of the utils descriptor and just check for binutils' existence (without adding any links) in mkbundle-windows.sh?

Just did that myself in commit 5a3ca06d4d031019aadc0a50aa209a5ca86c2b3f.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#10077 (closed)